Francesco Romani has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO ......................................................................
Patch Set 6: Code-Review-1 (1 comment) looks fine (hence +2 pending), but I have one question, so I -1'd for visibility only :\ https://gerrit.ovirt.org/#/c/60640/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1522: domxml.appendNumaTune() Line 1523: else: Line 1524: if (config.getboolean('vars', 'host_numa_scheduling') and Line 1525: self._devices[hwclass.HOSTDEV]): Line 1526: domxml.appendHostdevNumaTune(self._devices[hwclass.HOSTDEV]) fine. But does the schema allow Engine to send this explicitely? If not, what's missing? Line 1527: Line 1528: domxml._appendAgentDevice(self._guestSocketFile.decode('utf-8'), Line 1529: vmchannels.DEVICE_NAME) Line 1530: domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), -- To view, visit https://gerrit.ovirt.org/60640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
