Petr Horáček has posted comments on this change. Change subject: network: write out nameservers to ifcfg files ......................................................................
Patch Set 11: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/61184/11/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: PS11, Line 520: removal of kwargs should not be part of this patch. are we sure that **opts does not contain anything needed? https://gerrit.ovirt.org/#/c/61184/11/tests/network/config_network_test.py File tests/network/config_network_test.py: Line 165: 'management': {'defaultRoute': 'true'}, Line 166: 'vm': {}, Line 167: } Line 168: Line 169: canonicalize_networks(networks) it's strange that we look into netinfo in canonicalization, too late. could you create a new test module for canonicalization or dns and place the test there? Line 170: self.assertEqual(networks['management']['nameservers'], Line 171: FAKE_NAMESERVERS) -- To view, visit https://gerrit.ovirt.org/61184 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie10ee7938b26a7f3b2b7be80bc1a2a83cd1c376c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
