Tomas Golembiovsky has uploaded a new change for review.

Change subject: v2v: Bump version requirement on python-cpopen.
......................................................................

v2v: Bump version requirement on python-cpopen.

In order to support redirection of stderr to stdout we need to bump
version requirement on python-cpopen. This feature is broken in previous
versions.

Change-Id: I540180130a80f5c3c19007e10851b7713db596f9
Bug-Url: https://bugzilla.redhat.com/1350465
Signed-off-by: Tomáš Golembiovský <[email protected]>
---
M tests/v2vTests.py
M vdsm.spec.in
2 files changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/62093/1

diff --git a/tests/v2vTests.py b/tests/v2vTests.py
index 3978035..6d3a8f4 100644
--- a/tests/v2vTests.py
+++ b/tests/v2vTests.py
@@ -571,6 +571,13 @@
         out = p.stdout.read()
         self.assertEqual(out, msg)
 
+        p = v2v._simple_exec_cmd(['/bin/sh', '-c', 'echo -en "%s" >&2' % msg],
+                                 stdout=subprocess.PIPE,
+                                 stderr=subprocess.STDOUT)
+        p.wait()
+        out = p.stdout.read()
+        self.assertEqual(out, msg)
+
 
 class MockVirConnectTests(TestCaseBase):
     def setUp(self):
diff --git a/vdsm.spec.in b/vdsm.spec.in
index cc79f14..bf53001 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -82,7 +82,7 @@
 BuildRequires: policycoreutils-python
 BuildRequires: psmisc
 BuildRequires: PyYAML
-BuildRequires: python-cpopen >= 1.4
+BuildRequires: python-cpopen >= 1.4-1
 BuildRequires: python-inotify
 BuildRequires: python-ioprocess >= 0.16.1-1
 BuildRequires: python-pthreading


-- 
To view, visit https://gerrit.ovirt.org/62093
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I540180130a80f5c3c19007e10851b7713db596f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to