Edward Haas has posted comments on this change. Change subject: virt net: Support VM migration on OVS based networks ......................................................................
Patch Set 15: Verified+1 (2 comments) https://gerrit.ovirt.org/#/c/59645/14/vdsm/virt/vm_migrate_hook.py File vdsm/virt/vm_migrate_hook.py: Line 138: elem_source = interface.find('source') Line 139: elem_source.set('bridge', bridge) Line 140: Line 141: Line 142: def _set_graphics(devices, target_vm_conf): > Please add a TODO about supporting VMs with multiple <graphics> sections. Done Line 143: # TODO: Support VMs with multiple <graphics> sections. Line 144: graphics = devices.find('graphics') Line 145: if graphics is None: Line 146: return https://gerrit.ovirt.org/#/c/59645/13/vdsm/virt/vmdevices/graphics.py File vdsm/virt/vmdevices/graphics.py: PS13, Line 71: > actually, we should completely drop 'displayIp' from self.conf (in a differ Done -- To view, visit https://gerrit.ovirt.org/59645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d32f9605f9ca99d1e07062108f2567806ac59c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
