Tomas Golembiovsky has posted comments on this change. Change subject: compat: py3: capture output of CPopen.communicate ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/61393/3/lib/vdsm/commands.py File lib/vdsm/commands.py: Line 67: Line 68: execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd)) Line 69: Line 70: extra = {} Line 71: extra['stderr'] = subprocess.PIPE You're missing import subprocess. Line 72: extra['stdout'] = subprocess.PIPE Line 73: if deathSignal is not None: Line 74: extra['deathSignal'] = deathSignal Line 75: p = CPopen(command, close_fds=True, cwd=cwd, env=env, **extra) -- To view, visit https://gerrit.ovirt.org/61393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac9c1c1bd3ca1902103fac1f8675b7d42ca78a33 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
