Francesco Romani has posted comments on this change. Change subject: core: refactor: Move pathToVolID method ......................................................................
Patch Set 1: Code-Review-1 (3 comments) conceptually ok, we just need a few minor tweaks. -1 for visibility of the comments. https://gerrit.ovirt.org/#/c/62180/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-08-08 18:27:21 +0300 Line 4: Commit: Ala Hino <[email protected]> Line 5: CommitDate: 2016-08-08 20:35:12 +0300 Line 6: Line 7: core: refactor: Move pathToVolID method vm: refactor: move... Line 8: Line 9: Move pathToVolID method from _diskXMLGetVolumeChainInfo method to Line 10: module scope in order to reuse it in commit 8c52769(Live Merge: Line 11: Restore watermark tracking) PS1, Line 10: 8c52769 commit ID are going to change, courtesy of how gerrit works. Only IDs of committed patches (thus past commits) are going to be stable and fixed. So, please use change-id, or, equally good, just say "a future patch". https://gerrit.ovirt.org/#/c/62180/1/vdsm/virt/vm.py File vdsm/virt/vm.py: PS1, Line 156: pathToVolID we can afford the un-shortened name, and to use pep8 names: def path_to_volume_id(drive, path): # ... -- To view, visit https://gerrit.ovirt.org/62180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d8ef439120b8dff79cda9fcff7c42040f75e35e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
