Nir Soffer has submitted this change and it was merged.

Change subject: Remove _udevrulesdir global macro
......................................................................


Remove _udevrulesdir global macro

Patch 271dd9bca1288e732f8d80d98a3d022e5c466bcc changed the definition
of the "_udevrulesdir" global macro to use %{_libdir}, and with that
added a regression that prevents the udev rule "12-vdsm-lvm" from
being installed, which causes our logical volumes to be own by root.
This leads to a situation where libvirt cannot access them at all, so
for example, a Vm with a block domain cannot be started.

This patch removes this macro as it's already defined in macros.systemd.

Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da
Signed-off-by: Idan Shaby <ish...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/62196
Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com>
Reviewed-by: Allon Mureinik <amure...@redhat.com>
Tested-by: Eyal Edri <ee...@redhat.com>
Reviewed-by: Nir Soffer <nsof...@redhat.com>
Continuous-Integration: Nir Soffer <nsof...@redhat.com>
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Eyal Edri: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve
  Idan Shaby: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to