Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/59834/14/lib/vdsm/v2v.py File lib/vdsm/v2v.py: PS14, Line 816: FileIO > Thanks, this fully makes sense, but now I wonder: 1) That's because AsyncProc object does something similar to get rid of the simple File object. But instead of io.FileIO it has it's own implementation for accessing the FD (AsyncProc._streamedWrapper). It then wraps the AsyncProc._streamedWrapper object in io.BuffereReader just like we do here (both _streamedWrapper and io.FileIO are low-level and don't provide iterators). 2) We can give it a try later. -- To view, visit https://gerrit.ovirt.org/59834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
