Adam Litke has submitted this change and it was merged. Change subject: testlib: Use osutils.close_fd to avoid fd leaks ......................................................................
testlib: Use osutils.close_fd to avoid fd leaks If a child process exit when we close a file descriptor, the call may be interrupted, and we would not close the next fd. Change-Id: I5c8d2b7e29cc7df751d4fc1954ad3f3cae6917ce Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/61216 Reviewed-by: Adam Litke <ali...@redhat.com> --- M tests/testlib.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Verified; Passed CI tests Adam Litke: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/61216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c8d2b7e29cc7df751d4fc1954ad3f3cae6917ce Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
