Nir Soffer has posted comments on this change. Change subject: tests: Remove global sanlock mock ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/61996/2//COMMIT_MSG Commit Message: Line 8: Line 9: We're currently mocking the sanlock python module for all tests using a Line 10: hack in testrunner.py. Now that sanlock is available on all supported Line 11: platforms, just require that sanlock-python is installed. We can then Line 12: get rid of this hack. I don't think the mock was used because sanlock is not available on the platform, but because sanlock is not installed on a developer machine, and even if installed, it is not running, and sanlock api calls will fail. I think we still need this mock, but we should use only for tests that try to access sanlock. Line 13: Line 14: Change-Id: I11dc27d1143b9caa2ce026fe2299f757fca0c71d -- To view, visit https://gerrit.ovirt.org/61996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11dc27d1143b9caa2ce026fe2299f757fca0c71d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
