Nir Soffer has posted comments on this change. Change subject: storage: domainMonitor.getAllHostIds() API ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/61997/2//COMMIT_MSG Commit Message: Line 20: The second option avoids proliferating the domainMonitor and keeps the layers Line 21: more separated. The second option is also easier to test. This patch Line 22: implements it by adding a getAllHostIds() API to the domainMonitor which Line 23: returns this mapping. To illustrate its usage, SDM.copy_volume is enhanced to Line 24: receive this map for eventual use when acquiring volume leases. The second option also duplicate the state managed by the domain monitor, creating possibly inconsistent state in different parts of the application. Passing the domain monitor or another object providing the getHostId() sounds much better. Line 25: Line 26: Change-Id: If1d89bb114eea58387cd88d9da3c27b69d6affa3 -- To view, visit https://gerrit.ovirt.org/61997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1d89bb114eea58387cd88d9da3c27b69d6affa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
