Francesco Romani has posted comments on this change. Change subject: virt: vmchannels: switch to concurrent.thread() ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/61460/5//COMMIT_MSG Commit Message: Line 9: This patch: Line 10: 1. replaces good usages of threading.Thread() with Line 11: more modern concurrent.thread() Line 12: 2. replaces bad usages of threading.Thread() - inheritance Line 13: with composition, leveraging concurrent.thread() > Only one thread is modified by this patch - maybe this describes multiple p yes, will update the commit message(s). Line 14: Line 15: there are no intended changes in behaviour. Line 16: Line 17: Change-Id: I6d1c566c87ffac0cbfb5cc2b22587baa10760cf3 https://gerrit.ovirt.org/#/c/61460/5/lib/vdsm/virt/vmchannels.py File lib/vdsm/virt/vmchannels.py: Line 53: self._add_channels = {} Line 54: self._del_channels = [] Line 55: self._timeout = None Line 56: self._thread = concurrent.thread( Line 57: self.run, name='VM Channels Listener' > Lets use short lowercase names so system names and vdsm names are the same will do in a followup patch to keep this as trivial as possible Line 58: ) Line 59: Line 60: def start(self): Line 61: self._thread.start() -- To view, visit https://gerrit.ovirt.org/61460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d1c566c87ffac0cbfb5cc2b22587baa10760cf3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
