Edward Haas has posted comments on this change. Change subject: net: early IP+link setup ......................................................................
Patch Set 14: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/60371/14/lib/vdsm/network/restore.py File lib/vdsm/network/restore.py: Module names in a form of verbs are a a bit weird. How about 'restorer' or 'netrestorer' (sounds like a name for a movie). Line 1: # Copyright 2016 Red Hat, Inc. Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by https://gerrit.ovirt.org/#/c/60371/14/vdsm.spec.in File vdsm.spec.in: PS14, Line 1310: networks drop the 's' -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
