Irit Goihman has posted comments on this change. Change subject: functional tests: fix supervdsmServer test ......................................................................
Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/61902/11/tests/functional/Makefile.am File tests/functional/Makefile.am: Line 27: networkTestsOVS.py \ Line 28: sosPluginTests.py \ Line 29: supervdsmFuncTests.py \ Line 30: test_ksm_action.py \ Line 31: test_ping_call.py \ > those are helpers that you don't plan to run directly, why the test prefix? because they are still tests and are run with nosetest? Line 32: utils.py \ Line 33: virtTests.py \ Line 34: vmQoSTests.py \ Line 35: vmRecoveryTests.py \ https://gerrit.ovirt.org/#/c/61902/11/tests/functional/supervdsmFuncTests.py File tests/functional/supervdsmFuncTests.py: Line 32: Line 33: Line 34: class TestSuperVdsmRemotly(TestCaseBase): Line 35: def testPingCall(self): Line 36: p = subprocess.Popen > specify that it must run from /usr/share/vdsm/tests Done Line 37: ( Line 38: ['/usr/share/vdsm/tests/run_tests.sh', Line 39: 'functional/test_ping_call.py'] Line 40: ) -- To view, visit https://gerrit.ovirt.org/61902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
