Nir Soffer has posted comments on this change. Change subject: Adding units to cpu metrics name according to metrics2.0 spec ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62156/3/lib/vdsm/host/api.py File lib/vdsm/host/api.py: Line 104: Line 105: data[prefix + '.vms.active'] = hoststats['vmActive'] Line 106: data[prefix + '.vms.total'] = hoststats['vmCount'] Line 107: Line 108: data[prefix + '.cpu.load_5M'] = hoststats['cpuLoad'] > ok, but it's still in 5 minutes intervals.. so I assumed we would want the This is not intervals, not sure that we need unit info for something that does not have a unit. Line 109: data[prefix + '.cpu.user_jiff'] = hoststats['cpuUser'] Line 110: data[prefix + '.cpu.sys_jiff'] = hoststats['cpuSys'] Line 111: data[prefix + '.cpu.idle_jiff'] = hoststats['cpuIdle'] Line 112: data[prefix + '.cpu.sys_vdsmd_jiff'] = hoststats['cpuSysVdsmd'] -- To view, visit https://gerrit.ovirt.org/62156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I366280bf1c3783fdbbdd7459e49ae7fcf5e8b598 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
