Nir Soffer has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
......................................................................
Patch Set 3: Verified+1
Verified both positive and negative flows.
I could not reproduce the original error so I added a second call to extend a
volume in the mailbox thread, and this is how it looks now:
This request should fail:
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:20,517::lvm::288::Storage.Misc.excCmd::(cmd) /usr/bin/taskset --cpu-list
0-7 /usr/bin/sudo -n /usr/sbin/lvm lve
xtend --config ' devices { preferred_names = ["^/dev/mapper/"]
ignore_suspended_devices=1 write_cache_state=0 disable_after_error_count=3
filter = [ '\''a|/dev/mapper/360014
05292bb96f19064f81b884fa63f|/dev/mapper/360014052c81462a280847e8a6e3af8cd|/dev/mapper/360014054729dfdd84d1493a818924b0d|/dev/mapper/3600140549f3b93968d440ac9129d124f|/dev/ma
pper/360014054b9a6f2539574211b84356cff|/dev/mapper/360014055b413c342a134486b616d2359|/dev/mapper/360014056cbd26bc649c4862b55905337|/dev/mapper/3600140573f2afb2d0404862b37b08
cd6|/dev/mapper/360014057ce1a1afffd744dc8c34643d7|/dev/mapper/3600140587a66de91f05449a8cd9250b0|/dev/mapper/360014059e68c9a14a494de0bc808663b|/dev/mapper/36001405b6f4ebb5a45
6460c868ed8c7a|/dev/mapper/36001405c27599a89012467784cd463b4|/dev/mapper/36001405cc9ad490392b4277b52aec8d4|/dev/mapper/36001405d2aa1ad2c5ef4fa9820d93aa9|/dev/mapper/36001405
d2d73a8d22ae44a5a36bda08d|/dev/mapper/36001405ef22c7b9fbff43fa93aa78719|/dev/mapper/36001405f148e99c5a3e4781b292fd7e1|/dev/mapper/36001405f16755b12e6444158b55d57db|/dev/mapp
er/36001405fd7e668fdf80479992b012af8|'\'', '\''r|.*|'\'' ] } global {
locking_type=1 prioritise_write_locks=1 wait_for_locks=1 use_lvmetad=0 }
backup { retain_min = 5
0 retain_days = 0 } ' --autobackup n --size 2048m
65059e74-7577-4356-8ce1-89e9634d986b/c3eb6aec-e126-4a60-9a1c-a29aad9191d5 (cwd
None)
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:21,389::lvm::288::Storage.Misc.excCmd::(cmd) FAILED: <err> = ' New size
(16 extents) matches existing size (16 extents)\n'; <rc> = 5
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:21,394::lvm::288::Storage.Misc.excCmd::(cmd) /usr/bin/taskset --cpu-list
0-7 /usr/bin/sudo -n /usr/sbin/lvm lvs --config ' devices { preferred_names =
["^/dev/mapper/"] ignore_suspended_devices=1 write_cache_state=0
disable_after_error_count=3 filter = [
'\''a|/dev/mapper/36001405292bb96f19064f81b884fa63f|/dev/mapper/360014052c81462a280847e8a6e3af8cd|/dev/mapper/360014054729dfdd84d1493a818924b0d|/dev/mapper/3600140549f3b93968d440ac9129d124f|/dev/mapper/360014054b9a6f2539574211b84356cff|/dev/mapper/360014055b413c342a134486b616d2359|/dev/mapper/360014056cbd26bc649c4862b55905337|/dev/mapper/3600140573f2afb2d0404862b37b08cd6|/dev/mapper/360014057ce1a1afffd744dc8c34643d7|/dev/mapper/3600140587a66de91f05449a8cd9250b0|/dev/mapper/360014059e68c9a14a494de0bc808663b|/dev/mapper/36001405b6f4ebb5a456460c868ed8c7a|/dev/mapper/36001405c27599a89012467784cd463b4|/dev/mapper/36001405cc9ad490392b4277b52aec8d4|/dev/mapper/36001405d2!
aa1ad2c5ef4fa9820d93aa9|/dev/mapper/36001405d2d73a8d22ae44a5a36bda08d|/dev/mapper/36001405ef22c7b9fbff43fa93aa78719|/dev/mapper/36001405f148e99c5a3e4781b292fd7e1|/dev/mapper/36001405f16755b12e6444158b55d57db|/dev/mapper/36001405fd7e668fdf80479992b012af8|'\'',
'\''r|.*|'\'' ] } global { locking_type=1 prioritise_write_locks=1
wait_for_locks=1 use_lvmetad=0 } backup { retain_min = 50 retain_days = 0 }
' --noheadings --units b --nosuffix --separator '|' --ignoreskippedcluster -o
uuid,name,vg_name,attr,size,seg_start_pe,devices,tags
65059e74-7577-4356-8ce1-89e9634d986b (cwd None)
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:22,267::lvm::463::Storage.LVM::(_reloadlvs) lvs reloaded
e115170c-8bf5-42a7-bb3d-be261813d351::DEBUG::2016-08-15
23:35:22,268::lvm::1170::Storage.LVM::(_resizeLV) LV
65059e74-7577-4356-8ce1-89e9634d986b/c3eb6aec-e126-4a60-9a1c-a29aad9191d5
extend unneeded (size=2147483648, requested=2147483648)
--
To view, visit https://gerrit.ovirt.org/62338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id557df0b809f7ee141f2e9ea0e1c83084c71bb49
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]
