Hello Dan Kenigsberg, Edward Haas,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/62361

to review the following change.

Change subject: net tests: add a 'status' parameter to SetupNetworksError
......................................................................

net tests: add a 'status' parameter to SetupNetworksError

Change-Id: I1ed5e4672474584364705f399493f357eba86586
Signed-off-by: Ondřej Svoboda <osvob...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/62166
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas <edwa...@redhat.com>
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
---
M tests/network/netfunctestlib.py
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/62361/1

diff --git a/tests/network/netfunctestlib.py b/tests/network/netfunctestlib.py
index 54cd99f..fc5ae96 100644
--- a/tests/network/netfunctestlib.py
+++ b/tests/network/netfunctestlib.py
@@ -346,7 +346,10 @@
 
 
 class SetupNetworksError(Exception):
-    pass
+    def __init__(self, status, msg):
+        super(SetupNetworksError, self).__init__(msg)
+        self.status = status
+        self.msg = msg
 
 
 class SetupNetworks(object):
@@ -361,7 +364,7 @@
 
         status, msg = self.vdsm_proxy.setupNetworks(networks, bonds, options)
         if status != SUCCESS:
-            raise SetupNetworksError(msg)
+            raise SetupNetworksError(status, msg)
 
         try:
             self.post_setup_hook()
@@ -378,7 +381,7 @@
     def __exit__(self, type, value, traceback):
         status, msg = self._cleanup()
         if type is None and status != SUCCESS:
-            raise SetupNetworksError(msg)
+            raise SetupNetworksError(status, msg)
 
     def _cleanup(self):
         networks_caps = self.vdsm_proxy.netinfo.networks


-- 
To view, visit https://gerrit.ovirt.org/62361
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ed5e4672474584364705f399493f357eba86586
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to