Francesco Romani has posted comments on this change. Change subject: WIP vm: add utility to get sublogger ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/61992/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 222: (hwclass.MEMORY, vmdevices.core.Memory)) Line 223: Line 224: def get_logger(self, suffix=None): Line 225: if suffix is None: Line 226: return logging.getLogger(self.LOG_PREFIX) > Does this belong here? it does what I had in mind, this doesn't mean it was a good idea to begin with :) Line 227: return SimpleLogAdapter( Line 228: logging.getLogger(self.LOG_PREFIX + "." + suffix), Line 229: {"vmId": self.conf['vmId']} Line 230: ) Line 224: def get_logger(self, suffix=None): Line 225: if suffix is None: Line 226: return logging.getLogger(self.LOG_PREFIX) Line 227: return SimpleLogAdapter( Line 228: logging.getLogger(self.LOG_PREFIX + "." + suffix), > This will create a logger per vm - very bad idea, since loggers are never r good catch, fixing Line 229: {"vmId": self.conf['vmId']} Line 230: ) Line 231: Line 232: def _emptyDevMap(self): -- To view, visit https://gerrit.ovirt.org/61992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1a378a36de93ebf2ab2b9dcf099deed44f7765b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
