Sahina Bose has posted comments on this change.

Change subject: virt: enable glusterfs access through libgfapi interface
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/44061/8/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 321:                 if drive.get('diskType') == DISK_TYPE.NETWORK:
Line 322:                     volinfo = res['info']
Line 323:                     volPath = volinfo['path']
Line 324:                     drive['protocol'] = volinfo['protocol']
Line 325:                     # currently, single host is provided due to this 
bug:
> since this patch is for 4.1, and 4.1 will be on top of 7.3, I think we need
I think we should take in the support for additional hosts as an addon patch. 
it's a separate bz - https://bugzilla.redhat.com/show_bug.cgi?id=1322852
Line 326:                     # https://bugzilla.redhat.com/1247521
Line 327:                     drive['hosts'] = [volinfo['hosts'][0]]
Line 328:                 else:
Line 329:                     volPath = res['path']


-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Prasanna Kumar Kalever <prasanna.kale...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to