Nir Soffer has posted comments on this change.

Change subject: jsonrpc: shorten executor thread system names
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/61978/6/lib/vdsm/rpc/bindingjsonrpc.py
File lib/vdsm/rpc/bindingjsonrpc.py:

Line 34: class BindingJsonRpc(object):
Line 35:     log = logging.getLogger('BindingJsonRpc')
Line 36: 
Line 37:     def __init__(self, bridge, subs, timeout, scheduler, cif):
Line 38:         self._executor = executor.Executor(name="jsonrpcex",
Do we need the "ex" suffix? The executor worker threads will be named jsonrpc/0 
jsonrpc/1 ... - seems fine.
Line 39:                                            workers_count=_THREADS,
Line 40:                                            max_tasks=_TASKS,
Line 41:                                            scheduler=scheduler)
Line 42:         self._bridge = bridge


-- 
To view, visit https://gerrit.ovirt.org/61978
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibefc7d2c60d7b5d23739b129088f8e7f80514540
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to