Francesco Romani has posted comments on this change. Change subject: virt: migration: switch to concurrent.thread() ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/61463/9/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 556: def start(self): Line 557: self._thread.start() Line 558: Line 559: def join(self): Line 560: return self._thread.join() > Does `join' return anything? Nope[1], and this is slighlty misleading, albeit temporarily - It is going away with https://gerrit.ovirt.org/#/c/62587/1 But this is no reason to have a sloppy patch, fixing. +++ [1] It returns None, but it is not meaningful :) Line 561: Line 562: def is_alive(self): Line 563: return self._thread.is_alive() Line 564: -- To view, visit https://gerrit.ovirt.org/61463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23b98be05103529c827e6e21c0ed82cca58cb346 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
