Dan Kenigsberg has posted comments on this change.

Change subject: hook-fcoe is arch depended
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

-1 for visibility

https://gerrit.ovirt.org/#/c/62454/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: hook-fcoe is arch depended
Line 8: 
Line 9: Using %post script in sub-package of arch depended package requires to
Line 10: declare the package as arch depended.
could you explain this statement? (maybe with a url to Fedora standards)

all we have is

 %post hook-fcoe
 %systemd_post lldpad.service
 %systemd_post fcoe.service

which seems noarch to me.
Line 11: 
Line 12: Change-Id: Ic59d7e29a75b13e1fc39b58a8d1252d6d2971058


-- 
To view, visit https://gerrit.ovirt.org/62454
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59d7e29a75b13e1fc39b58a8d1252d6d2971058
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to