Petr Horáček has posted comments on this change. Change subject: net tests: separate a resolv.conf test from NetInfo tests ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/62723/1/tests/network/resolv_test.py File tests/network/resolv_test.py: Line 17: # 02110-1301 USA Line 18: # Line 19: # Refer to the README and COPYING files for full details of the license Line 20: # Line 21: from __future__ import absolute_import empty line after __future__ Line 22: import os Line 23: Line 24: from nose.plugins.attrib import attr Line 25: Line 41: ] Line 42: Line 43: def test_get_host_nameservers(self): Line 44: nameservers = ['192.168.0.100', '8.8.8.8', '8.8.4.4'] Line 45: with namedTemporaryDir() as temp_dir: could you please replace namedTemporaryDir() with mock.mock_open(). here or in a following patch. Line 46: file_path = os.path.join(temp_dir, 'resolv.conf') Line 47: Line 48: with mock.patch.object(resolv, 'DNS_CONF_FILE', file_path): Line 49: for content in (self.RESOLV_CONF, self.RESOLV_CONF + ['\n']): -- To view, visit https://gerrit.ovirt.org/62723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I566f3450f849df65e8b0c427ff883d7e6c9223d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
