Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62737
to review the following change.
Change subject: lvm: Improve logging lv activation logging
......................................................................
lvm: Improve logging lv activation logging
Log vg name and lv names when we activate, refresh or deactivate lvs.
All are important state changes that should be logged in INFO level.
The actual lvm commands are logged in DEBUG level, and may not be
available when we change the default log level to INFO.
Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d
Bug-Url: https://bugzilla.redhat.com/1358348
Signed-off-by: Nir Soffer <nsof...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/61286
Reviewed-by: Allon Mureinik <amure...@redhat.com>
Reviewed-by: Adam Litke <ali...@redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/storage/lvm.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/62737/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 05b4582..03cf211 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -1200,9 +1200,11 @@
inactive.append(lvName)
if active:
+ log.info("Refreshing lvs: vg=%s lvs=%s", vgName, active)
refreshLVs(vgName, active)
if inactive:
+ log.info("Activating lvs: vg=%s lvs=%s", vgName, inactive)
_setLVAvailability(vgName, inactive, "y")
@@ -1210,6 +1212,7 @@
toDeactivate = [lvName for lvName in lvNames
if _isLVActive(vgName, lvName)]
if toDeactivate:
+ log.info("Deactivating lvs: vg=%s lvs=%s", vgName, toDeactivate)
_setLVAvailability(vgName, toDeactivate, "n")
--
To view, visit https://gerrit.ovirt.org/62737
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
