Piotr Kliczewski has posted comments on this change. Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/62383/5/vdsm_hooks/vhostmd/after_vm_destroy.py File vdsm_hooks/vhostmd/after_vm_destroy.py: PS5, Line 33: items > actually when checking it I saw that items is returned: In my opinion we should keep the original key because it could introduce inconsistency across the clients. -- To view, visit https://gerrit.ovirt.org/62383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
