Shahar Havivi has posted comments on this change. Change subject: v2v: filter out Xen VMs with block storage ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/62368/1//COMMIT_MSG Commit Message: Line 6: Line 7: v2v: filter out Xen VMs with block storage Line 8: Line 9: virt-v2v is not support importing Xen VMs with block storage domain. Line 10: No need to return these VMs via get_external_vms verb > Shouldn't we rather behave like with snapsnots and running VMs and leave th There is no filter in the engine for snapshots... (there is an RFE but solution not dissected yet). In this case its limited that will never be solved (block for Xen on Rhel 5.x) so I think filtering in vdsm is ok. Line 11: Line 12: Change-Id: I84512f54f9949640a568a444dd7eeb78db852134 Line 13: Bug-Url: https://bugzilla.redhat.com/1365411 -- To view, visit https://gerrit.ovirt.org/62368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Golembiovsky <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
