Milan Zamazal has posted comments on this change. Change subject: vmdisk hook: add support for booting from image file ......................................................................
Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/58748/6/vdsm_hooks/vmdisk/before_vm_start.py File vdsm_hooks/vmdisk/before_vm_start.py: PS6, Line 70: [] > Tried and failed. Not sure why, my python knowledge is not so good :) Basically, you need to use .add instead of .append with sets. PS6, Line 84: sorted(boo > Done I don't think `sorted' makes much sense here, especially if a set is used instead of a list. https://gerrit.ovirt.org/#/c/58748/7/vdsm_hooks/vmdisk/before_vm_start.py File vdsm_hooks/vmdisk/before_vm_start.py: Line 116: hooking.write_domxml(domxml) Line 117: except: Line 118: sys.stderr.write('vmdisk: [unexpected error]: %s\n' % Line 119: traceback.format_exc()) Line 120: sys.exit(2) Please add a newline character at the end of this last line, otherwise the style checking tools complain and continuous integration fails. -- To view, visit https://gerrit.ovirt.org/58748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9b3f6239f3c58a9f9497e74e5d9c8993d78d81e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dmitry Glushenok <dglushe...@yandex.ru> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dmitry Glushenok <dglushe...@yandex.ru> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
