Adam Litke has posted comments on this change. Change subject: Live Merge: Restore watermark tracking ......................................................................
Patch Set 13: (2 comments) https://gerrit.ovirt.org/#/c/60889/13/vdsm/virt/vm.py File vdsm/virt/vm.py: PS13, Line 931: ret.append((drive, drive.volumeID, capacity, alloc, : physical)) This does not need to be moved inside the try block. You can keep it after (like it was originally) and minimize changes. PS13, Line 4752: COW' > in a separate patch please fix in this patch. Otherwise we're introducing too much noise into the commit history. -- To view, visit https://gerrit.ovirt.org/60889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
