Piotr Kliczewski has posted comments on this change. Change subject: dump_volume_chains: migrate to jsonrpcvdscli ......................................................................
Patch Set 11: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/62324/11/lib/vdsm/tool/dump_volume_chains.py File lib/vdsm/tool/dump_volume_chains.py: PS11, Line 160: items Please make sure that we do not change the key names. It creates inconsistency across the clients. We need to keep imageslist PS11, Line 165: items same here -- To view, visit https://gerrit.ovirt.org/62324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org