Edward Haas has uploaded a new change for review. Change subject: net: dhclient command - iface name should appear at the tail ......................................................................
net: dhclient command - iface name should appear at the tail dhclient lookup is expecting the iface on which the dhclient runs to appear at the end of the command. When running dhclient directly (not through ifcfg), this is not the case. This patch places the iface at the tail of the command. Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9 Signed-off-by: Edward Haas <edwa...@redhat.com> --- M lib/vdsm/network/ip/dhclient.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/62829/1 diff --git a/lib/vdsm/network/ip/dhclient.py b/lib/vdsm/network/ip/dhclient.py index d69e70b..3fc5b33 100644 --- a/lib/vdsm/network/ip/dhclient.py +++ b/lib/vdsm/network/ip/dhclient.py @@ -60,12 +60,13 @@ if os.path.exists(os.path.join(NET_PATH, self.iface)): kill(self.iface, self.family) cmd = [DHCLIENT_BINARY.cmd, '-%s' % self.family, '-1', '-pf', - self.pidFile, '-lf', self.leaseFile, self.iface] + self.pidFile, '-lf', self.leaseFile] if not self.default_route: # Instruct Fedora/EL's dhclient-script not to set gateway on iface cmd += ['-e', 'DEFROUTE=no'] if self.duid_source_file and supports_duid_file(): cmd += ['-df', self.duid_source_file] + cmd += [self.iface] cmd = cmdutils.systemd_run(cmd, scope=True, slice=self._cgroup) return execCmd(cmd) -- To view, visit https://gerrit.ovirt.org/62829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org