Petr Horáček has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. ......................................................................
Patch Set 1: Code-Review+1 (2 comments) just a nit and question https://gerrit.ovirt.org/#/c/62831/1/lib/vdsm/network/link/setup.py File lib/vdsm/network/link/setup.py: Line 25: Line 26: from .bond import Bond Line 27: Line 28: Line 29: class SetupBonds(object): will there be a Transaction? Line 30: def __init__(self, bonds2add, bonds2edit, bonds2remove): Line 31: self._bonds2add = bonds2add Line 32: self._bonds2edit = bonds2edit Line 33: self._bonds2remove = bonds2remove PS1, Line 44: set frozenset? -- To view, visit https://gerrit.ovirt.org/62831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
