Michal Skrivanek has posted comments on this change.

Change subject: Added a support for a guest hibernate command.
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/vm.py
Line 928:                 self._acpiShutdown()
Line 929:             # No tools, no ACPI
Line 930:             else:
Line 931:                 return {'status': {'code': 
errCode['exist']['status']['code'],
Line 932:                         'message': 'VM without ACPI or active oVirt 
tools. Try forced shutdown.'}}
"guest tools" would be better
Line 933:         except:
Line 934:             self.log.error("Shutdown failed", exc_info=True)
Line 935:         return {'status': {'code': doneCode['code'],
Line 936:                 'message': 'Machine shut down'}}


--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to