Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 669: Line 670: now = time.time() Line 671: if self._in_post_copy: Line 672: self._vm.log.debug('Post-copy migration still in progress: %d', Line 673: progress.data_remaining) > OK, at this stage "progress" is probably the only thing we need. As for stats, according to Arik, it's not a problem if they are not available in one sampling cycle (run every 15 seconds), but it's not acceptable if they are not available for let's say one minute. While post-copy migration is currently supposed to be fast (migration bandwith limits don't apply, which is a QEMU/libvirt bug), there's no guarantee it doesn't take long time for whatever reason. So we should be ready to handle that. I suggest making a followup patch that will ask the destination host for the VM stats if the post-copy phase takes more than some time to finish. What do you think? Do we already use some sort of direct communication between the hosts anywhere in Vdsm? Line 674: elif not self._use_conv_schedule and\ Line 675: (0 < migrationMaxTime < now - self._startTime): Line 676: self._vm.log.warn('The migration took %d seconds which is ' Line 677: 'exceeding the configured maximum time ' -- To view, visit https://gerrit.ovirt.org/62873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
