Petr Horáček has posted comments on this change.

Change subject: net: support configuring nameservers by ovs
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/62706/3/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

PS3, Line 244:         resolv.update(attrs['nameservers'])
> How is that different from setting the default route or changing the manage
Unlike this they are temporary non-persistent changes. We can also introduce 
resolv transaction (using atomic writer).


-- 
To view, visit https://gerrit.ovirt.org/62706
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe4f82fe88e24b43e5f40e96ae4292ebf933a8e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to