Petr Horáček has posted comments on this change. Change subject: net: Adding the 'link' package with an iface module ......................................................................
Patch Set 6: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/62827/6/lib/vdsm/network/link/iface.py File lib/vdsm/network/link/iface.py: PS6, Line 54: def is_admin_up(dev): : return link.is_link_up(link.get_link(dev)['flags'], check_link=False) : : : def is_link_up(dev): : return link.is_link_up(link.get_link(dev)['flags'], check_link=True) I'm confused. Both is_admin_up and also is_link_up uses is_link_up. plus paramater check_link for is_link_up looks weird PS6, Line 74: info debug? -- To view, visit https://gerrit.ovirt.org/62827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
