Petr Horáček has posted comments on this change. Change subject: net: Relocating wait-for-event under its own module. ......................................................................
Patch Set 3: Code-Review-1 (1 comment) nit https://gerrit.ovirt.org/#/c/62876/3/lib/vdsm/network/netlink/waitfor.py File lib/vdsm/network/netlink/waitfor.py: Line 32: yield Line 33: Line 34: Line 35: @contextmanager Line 36: def waitfor_ipv6_addr(iface, timeout=10): this and ipv4 wait can be defined via partial (but we must decide if we want to set fixed timeout or require it). waitfor_ipv6_addr = partial(_wait_for_event, expected_event={event}, timeout=10) Line 37: expected_event = {'label': iface, 'family': 'inet6', 'scope': 'global'} Line 38: with _wait_for_event(iface, expected_event, timeout): Line 39: yield Line 40: -- To view, visit https://gerrit.ovirt.org/62876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie99c93083fd4db7a2d20518c06e70da5bc333a71 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
