Edward Haas has posted comments on this change. Change subject: net: dhclient - address flush before starting and on shutdown ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63088/1/lib/vdsm/network/ip/dhclient.py File lib/vdsm/network/ip/dhclient.py: Line 63: Line 64: def _dhclient(self): Line 65: if iface.exists(self.iface): Line 66: kill(self.iface, self.family) Line 67: address.flush(self.iface, family=self.family) > There is extra_ipv4_addrs hook. For two static IP/s (or more), not for static+dynamic. please check the history, the flush was there originally in kill (in its older name) and I am pretty sure dhclient will not support such a thing anyway. Line 68: Line 69: cmd = [DHCLIENT_BINARY.cmd, '-%s' % self.family, '-1', '-pf', Line 70: self.pidFile, '-lf', self.leaseFile] Line 71: cmd += ['-R', DhcpClient.DEFAULT_REQ_OPTIONS] -- To view, visit https://gerrit.ovirt.org/63088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
