Vinzenz Feenstra has uploaded a new change for review. Change subject: vdsm: Attaching a console should be controllable ......................................................................
vdsm: Attaching a console should be controllable Added a new VmParameter 'attachConsole' which defines whether or not a console should be attached upon creation Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186 Signed-off-by: Vinzenz Feenstra <[email protected]> --- M vdsm/libvirtvm.py M vdsm_api/vdsmapi-schema.json 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/9359/1 diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py index ca31a43..16e081f 100644 --- a/vdsm/libvirtvm.py +++ b/vdsm/libvirtvm.py @@ -1260,7 +1260,9 @@ _QEMU_GA_DEVICE_NAME) domxml.appendInput() domxml.appendGraphics() - domxml.appendConsole() + + if utils.tobool(self.conf.get('attachConsole', 'false')): + domxml.appendConsole() for devType in self._devices: for dev in self._devices[devType]: diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 6591410..f736307 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -2379,6 +2379,9 @@ # # @vmType: The type of VM # +# @attachConsole: Defines if a virtio-console should be attached to the +# virtual machine +# # Since: 4.10.0 ## {'type': 'VmParameters', @@ -2388,7 +2391,7 @@ 'nice': 'int', 'smp': 'uint', 'smpCoresPerSocket': 'uint', 'smpThreadsPerCore': 'uint', 'timeOffset': 'uint', 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str', - 'vmType': 'VmType'}} + 'vmType': 'VmType', 'attachConsole': 'bool'}} ## # @VmInfo: -- To view, visit http://gerrit.ovirt.org/9359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
