Nir Soffer has posted comments on this change. Change subject: storage: py3: misc.py compliance ......................................................................
Patch Set 5: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/63192/5/lib/vdsm/storage/misc.py File lib/vdsm/storage/misc.py: Line 104 Line 105 Line 106 Line 107 Line 108 Such changes may break all storage flows using this infrastructure. Log skipping should be removed instead of making it work with Python 3. Best separate these changes to another patch. Line 34: import logging Line 35: import os Line 36: import random Line 37: import re Line 38: import six six is not builtin module, should be imported below. Line 39: import string Line 40: import struct Line 41: import threading Line 42: import weakref Line 44: from array import array Line 45: from collections import defaultdict Line 46: from functools import wraps, partial Line 47: from itertools import chain Line 48: import six here Line 49: from six.moves import queue Line 50: from six.moves import map Line 51: Line 52: from vdsm import commands https://gerrit.ovirt.org/#/c/63192/5/tests/Makefile.am File tests/Makefile.am: Line 160 Line 161 Line 162 Line 163 Line 164 > as you wish, I think there are more tests that pass after this change so th I would like to separate this to another patch. -- To view, visit https://gerrit.ovirt.org/63192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <leon.ot...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
