Liron Aravot has posted comments on this change. Change subject: implementing StorageDomain.movePV ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63270/1/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 1119: # Now add blockSD specific data Line 1120: vg = lvm.getVG(self.sdUUID) # vg.name = self.sdUUID Line 1121: info['vguuid'] = vg.uuid Line 1122: info['state'] = vg.partial Line 1123: info['metadatadevice'], _ = lvm.getFirstExt(self.sdUUID, sd.METADATA) > Are you sure this is part of this patch? Seems to belong to the top patch i Done Line 1124: return info Line 1125: Line 1126: def getStats(self): Line 1127: """ -- To view, visit https://gerrit.ovirt.org/63270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
