Piotr Kliczewski has posted comments on this change. Change subject: jsonvdscli: change hostname default ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/61782/5/tests/stompAsyncDispatcherTests.py File tests/stompAsyncDispatcherTests.py: Line 58: def queue_frame(self, frame): Line 59: self._outbox.append(frame) Line 60: Line 61: Line 62: class TestDispatcher(object): > In another patch it better be called something that hints it is a mock/fake Done Line 63: Line 64: socket = None Line 65: Line 66: def __init__(self, data): -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
