Edward Haas has posted comments on this change. Change subject: net: early IP+link setup ......................................................................
Patch Set 20: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/60371/20/lib/vdsm/network/netrestore.py File lib/vdsm/network/netrestore.py: PS20, Line 60: try: : netswitch.setup_ipv6autoconf({net: attrs}) : except Exception: : logging.exception('IPv6autoconf for {} failed.'.format(net)) Looks like a pattern you can reuse using a contextmanager: with _try2execute(log='...'): ...run... Line 65: for net, attrs in six.iteritems(nets): Line 66: try: Line 67: netswitch.set_ovs_links_up({net: attrs}, {}, {}) Line 68: except Exception: Line 69: logging.exception('Setting links up for {} failed.'.format(net)) Question: this includes the exception trace, right? Line 70: Line 71: for bond, attrs in six.iteritems(bonds): Line 72: try: Line 73: netswitch.set_ovs_links_up({}, {bond: attrs}, {}) -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
