Edward Haas has posted comments on this change. Change subject: net: Introduce iface.exists and start using it in ip.dhclient ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/63086/1/lib/vdsm/network/ip/dhclient.py File lib/vdsm/network/ip/dhclient.py: PS1, Line 31: iface > you've already used the term "linkiface" for this module. let's keep that h Done PS1, Line 48: _ > that's too painful to the eye; you could use dhclient_iface if you really w Done -- To view, visit https://gerrit.ovirt.org/63086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcece92726e7ef354b4792aee73bfc90fa5f3133 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
