Edward Haas has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/63119/1/lib/vdsm/network/kernelconfig.py File lib/vdsm/network/kernelconfig.py: PS1, Line 210: "mode" > we can use this patch to get a rid of nasty double quotes I can try :) PS1, Line 211: "mode" > 'mode' Done https://gerrit.ovirt.org/#/c/63119/1/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 162: with Transaction(in_rollback=in_rollback) as config: Line 163: with ifacquire.Transaction(ovs_netinfo['networks']) as acq: Line 164: with ovs_switch.create_setup(_ovs_info) as setup_ovs: Line 165: setup_ovs.remove_nets(nets2remove) Line 166: setup_bonds.remove_bonds() > We must update running config on each bond 'row' change, so we will be able Done Line 167: setup_bonds.edit_bonds() Line 168: setup_bonds.add_bonds() Line 169: setup_ovs.add_nets(nets2add) Line 170: acq.acquire(setup_bonds.acquired_ifaces) -- To view, visit https://gerrit.ovirt.org/63119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
