Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63427
to review the following change.
Change subject: storage: Remove unneeded multipath call
......................................................................
storage: Remove unneeded multipath call
As part of multipath rescan, we call iscsi and hba rescan.
These operations are sufficient to discover new devices and
detect changes in size.
Therefore, the multipath call is not needed and can be removed
improving the overall performance of GetDeviceList verb.
Also, the multipath call is risky as it may get stuck.
Detailed profiling :
time filename:lineno(function)
3.178 |hsm.py:1948(HSM._getDeviceList)
1.546 |--> sdc.py:80(StorageDomainCache.refreshStorage)
1.489 |--> multipath.py:65(rescan)
0.481 |--> iscsi.py:431(rescan) iscsi scan
0.076 |--> storage/hba.py:53(rescan) fc scan
0.912 |--> multipath.py:88(multipath) multipath
0.056 |--> multipath.py:92(resize_devices)
0.756 |--> lvm.py:843(getAllPVs)
0.756 |--> lvm.py:317(LVMCache._reloadpvs)
0.755 |--> lvm.py:290(LVMCache.cmd) pvs
0.871 |--> multipath.py:213(pathListIter)
0.029 |-->devicemapper.py:176(getPathsStatus) dmsetup status
Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Bug-Url: https://bugzilla.redhat.com/1303578
Signed-off-by: Fred Rolland <froll...@redhat.com>
---
M vdsm/storage/multipath.py
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/63427/1
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index 5c0bab6..83352c2 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -30,7 +30,6 @@
from collections import namedtuple
from vdsm import commands
-from vdsm import constants
from vdsm import supervdsm
from vdsm import udevadm
from vdsm import utils
@@ -73,9 +72,6 @@
# First rescan iSCSI and FCP connections
iscsi.rescan()
hba.rescan()
-
- # Now let multipath daemon pick up new devices
- misc.execCmd([constants.EXT_MULTIPATH], sudo=True)
# Scanning SCSI interconnects starts a storm of udev events. Wait until all
# events are processed, ensuring detection of new devices and creation or
--
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Fred Rolland <froll...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
