Federico Simoncelli has posted comments on this change.
Change subject: avoid creating hangover in storage domain cache after formatting
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2453: finally:
Line 2454: try:
Line 2455: sdCache.manuallyRemoveDomain(sdUUID)
Line 2456: except KeyError:
Line 2457: self.log.warn("Storage domain %s doesn't exist in
cache. "
Really minor: I don't like two sentences in one log message (you could use a
comma instead of a full stop).
Line 2458: "Leftovers are recycled.", sdUUID)
Line 2459:
Line 2460: @public
Line 2461: def formatStorageDomain(self, sdUUID, autoDetach=False,
options=None):
--
To view, visit http://gerrit.ovirt.org/8144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13a97ad6830553cbd099189dfb82d6f02ce82fe
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
