Michal Skrivanek has posted comments on this change. Change subject: vdsm: Attaching a console should be controllable ......................................................................
Patch Set 3: "true, but now that it becomes an engine managed device, question is if it shouldn't be managed as a device" there can be only one. It doesn't make sense to have multiple, Linux supports only 1, Windows doesn't support it at all. "how about controlling the communication to the console (serial/virtio)? Ancient guest operating system - that does not have virtio - may need/want this." true. however: - in ovirt we support only recent enough anyway - iirc there are some issues with virtio-serial implementation and qemu/kvm is planning to get rid of the code longterm. at least that's what i've heard:-) so - is it worth it? do we want to expose it in the engine? or maybe just allow it in vdsm? -- To view, visit http://gerrit.ovirt.org/9359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
