Petr Horáček has posted comments on this change. Change subject: net: Expose owned_device method through the configurator ......................................................................
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/63442/4/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 284: self._removeSourceRouteFile('rule', device) Line 285: self._removeSourceRouteFile('route', device) Line 286: Line 287: @staticmethod Line 288: def owned_device(device): ifcfg files should be touched by ConfigWriter, i think we should call a ConfigWriter method from here. Line 289: try: Line 290: with open(misc.NET_CONF_PREF + device) as conf: Line 291: content = conf.read() Line 292: except IOError as ioe: -- To view, visit https://gerrit.ovirt.org/63442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
