Edward Haas has posted comments on this change. Change subject: net: ifcfg - dhclient should always be stopped ......................................................................
Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/62832/11/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: PS11, Line 536: FIXME > More like TODO, it is not broken, is it? 'TODO' is too light for this one, we should move it out ASAP. I consider FIXME more urgent to do. Line 533: elif ipv4.bootproto: Line 534: cfg += 'BOOTPROTO=%s\n' % pipes.quote(ipv4.bootproto) Line 535: Line 536: # FIXME: Move this out, it is unrelated to a conf file creation. Line 537: if os.path.exists(os.path.join(NET_PATH, name)): > It is strange to have the code here. Does that test problem happen only wit It starts with 'ifcfg', isn't that enough? I'm going to fix this anyway soon (after closing up the bond patches) Line 538: # Ask dhclient to stop any dhclient running for the device Line 539: dhclient.kill(name) Line 540: address.flush(name, family=4) Line 541: -- To view, visit https://gerrit.ovirt.org/62832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
