Nir Soffer has posted comments on this change. Change subject: storage: Add support for guarded to ResourceManager ......................................................................
Patch Set 1: (2 comments) Tiny cleanup possible if you like to resubmit. https://gerrit.ovirt.org/#/c/63548/1/tests/resourceManagerTests.py File tests/resourceManagerTests.py: Line 743: self.assertFalse(a < b) Line 744: self.assertFalse(b < a) Line 745: Line 746: def test_acquire_release(self): Line 747: fake_rm = FakeResourceManager() Lets move this line below... Line 748: Line 749: lock = resourceManager.ResourceManagerLock( Line 750: 'ns_A', 'name_A', resourceManager.LockType.shared) Line 751: lock._rm = fake_rm Line 747: fake_rm = FakeResourceManager() Line 748: Line 749: lock = resourceManager.ResourceManagerLock( Line 750: 'ns_A', 'name_A', resourceManager.LockType.shared) Line 751: lock._rm = fake_rm ...here: Lock._rm = fake_rm = FakeResourceManager() Line 752: expected = [] Line 753: lock.acquire() Line 754: expected.append(('acquireResource', Line 755: (lock.ns, lock.name, lock.mode), {})) -- To view, visit https://gerrit.ovirt.org/63548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
